Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added icons in BMI Calculator #889

Merged
merged 1 commit into from
May 26, 2024
Merged

Added icons in BMI Calculator #889

merged 1 commit into from
May 26, 2024

Conversation

Vikashchou-dhary
Copy link
Contributor

@Vikashchou-dhary Vikashchou-dhary commented May 26, 2024 •
edited by Rakesh9100
Loading

Fixes Issue🛠️

Closes #693

Description👨‍💻

I have added icons of male and female in the BMI calculator.

Type of change📄

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How this has been tested✅

I browse the website in my own laptop and check the correction made.

Checklist✅

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added demonstration in the form of GIF/video file
  • I am an Open Source Contributor

Screenshots/GIF📷

bmi

@Vikashchou-dhary
Rakesh9100#693 solved
63eb79e 
I have made necessary changes and add icon to the BMI calculator
@netlify Netlify
Copy link

netlify bot commented May 26, 2024 •
edited
Loading

✅ Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit 63eb79e
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/6652edf7dab63e0008e67a37
😎 Deploy Preview https://deploy-preview-889--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot]
github-actions bot reviewed May 26, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Vikashchou-dhary, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

@Rakesh9100 Rakesh9100 changed the title #693 solved Added icons in BMI Calculator May 26, 2024
@Rakesh9100 Rakesh9100 merged commit a277640 into Rakesh9100:main May 26, 2024
5 checks passed
@Rakesh9100
Copy link
Owner

Congrats on getting your PR merged to the repo under GSSOC 2k24 🥳 @Vikashchou-dhary

@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSoC 2k24 Open Source Program level1 GSSoC2k24 Level-1 Task -- 10 Points labels May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions github-actions left review comments

Assignees

@Vikashchou-dhary Vikashchou-dhary

Labels
Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSoC 2k24 Open Source Program level1 GSSoC2k24 Level-1 Task -- 10 Points
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Style] Add icons in BMI Calculator
2 participants
@Vikashchou-dhary @Rakesh9100